Hi Fabio,
On 23/04/2015 19:18, Fabio Estevam wrote:
What about to export your is_hummingboard() function as U-Boot command ? You can then use it in U-Boot scripts, and the correct fdt name can be set in the "bootcmd" variable. Something like "if is_humming;then ..."
I am not sure how I can retrieve the returned value from is_hummingboard() as a U-boot command and use it inside a script? Maybe I did not understand your suggestion. Please advise.
U_BOOT_CMD returns a value that can be evaluated, exactly as we do with "if tftp.." or for other commands. So you could implement:
U_BOOT_CMD(is_hummingbird, 1, 1, do_is_hummingbird, ..
and the do_is_hummingbird can return CMD_RET_SUCCESS or CMD_RET_FAILURE. This is then evaluated in the script as "if is_hummingbird;then fdt_file=....;else fdt_file=...;fi"
And if a user wants to use other names, he can because it is not hard-coded.
Yes, I understand the concern, but in this specific case we are talking about a DTB file, which is board specific and cannot really change.
Well, maybe I am alone, but I am used to have several DTB files during the developmnet phase - I agree with you that at the end there should be only one DTB file.
Anyway, my was only a proposal - it is also fine if you decide to maintain the current implementation.
Best regards, Stefano Babic