On Sun, 10 Oct 2021 21:36:56 +0800 Chukun Pan amadeus@jmu.edu.cn wrote:
Hi Andre,
Please don't include not-yet-merged parts in here. Make a verbatim copy of the version in Linus' tree.
Okay, I remove the not-yet-merged parts in dts.
who is reading the MAC address out of the EEPROM, and how does it land in the kernel (if it lands there)?
There is a rtl8153 usb network card on this machine, and it will randomly generate a mac address when it bootup. I think the mac address on the eeprom is for this rtl8153 usb network card.
Well, fair enough, but how does this MAC address end up in the USB MAC? I guess this misses some code, but IIUC Chen-Yu pointed you to the solution already in the Linux thread.
So why is CONFIG_MACPWR missing from the defconfig?
This is my mistake, I'm very sorry about that.
Many thanks for the quick turnaround, that looks alright now. I will push it as part of the sunxi PR for v2022.01.
Thanks, Chukun
Chukun Pan (1): sunxi: Add support for FriendlyARM NanoPi R1S H5
Reviewed-by: Andre Przywara andre.przywara@arm.com
Cheers, Andre
arch/arm/dts/Makefile | 1 + arch/arm/dts/sun50i-h5-nanopi-r1s-h5.dts | 195 +++++++++++++++++++++++ board/sunxi/MAINTAINERS | 5 + configs/nanopi_r1s_h5_defconfig | 14 ++ 4 files changed, 215 insertions(+) create mode 100644 arch/arm/dts/sun50i-h5-nanopi-r1s-h5.dts create mode 100644 configs/nanopi_r1s_h5_defconfig