On Wednesday, March 16, 2011 04:04:42 Xie Shaohui-B21989 wrote:
On Tuesday, March 15, 2011 22:53:20 Shaohui Xie wrote:
--- a/drivers/mtd/spi/spi_flash.c +++ b/drivers/mtd/spi/spi_flash.c +#ifndef CONFIG_FSL_ESPI ........ +#else ........ +#endif
yikes, this cant be right
[Xie Shaohui] Could you shed more light on this, I didn't get your point, I guess It's maybe the behavior the transaction being handled, for espi controller, software cannot control the chip selects directly, software need to tell the controller how long the CS signal need to be asserted. Driver need to combine the CMD and data together in one transaction, it cannot call spi_xfer two times, first for CMD, and second for data.
in the previous thread with Kumar, we discussed changing things to always be "atomic". so if you want to pick up killing off SPI_XFER_{BEGIN,END} in the spi flash code, then feel free. but that's the only way forward i see at this point -- bus-specific ifdef's in spi flash code isnt going to be accepted. -mike