Stephen,
On Wed, Jan 16, 2013 at 3:32 PM, Stephen Warren swarren@wwwdotorg.org wrote:
On 01/16/2013 02:14 PM, Tom Warren wrote:
Common Tegra files are in arch-tegra, shared between T20/T30/T114. Tegra114-specific headers are in arch-tegra114. Note that some of these will be filled in as more T114 support is added (drivers, WB/LP0 support, etc.).
diff --git a/arch/arm/include/asm/arch-tegra114/gpio.h b/arch/arm/include/asm/arch-tegra114/gpio.h
I think the Tegra30 and Tegra114 GPIO controllers are basically identical. Can this file be shared at all?
gpio.h is identical for T30 and T114, but not for T20. I've already commonized what I could in arch-tegra/gpio.h, but to do the same for the gpio_ctlr struct and gpio_pin enums would involve #ifdefs, which is moving in the wrong direction, IMO. If you have a way to share one or two files between T20/T30/T114/future SoCs, I'll give it a try.
diff --git a/arch/arm/include/asm/arch-tegra114/tegra.h b/arch/arm/include/asm/arch-tegra114/tegra.h
+#define BCT_ODMDATA_OFFSET 6116 /* 12 bytes from end of BCT */
That's the Tegra30 value. I'm pretty sure the Tegra30 and Tegra114 BCTs are laid out very differently, so this value isn't valid.
True, and I have a fix (T114 BIT pointers moved, as did the BCT ODMDATA offset - I'd assumed they'd stay the same since T30 and T114 are so similar). It'll be in V2.
Thanks,
Tom