Re: [U-Boot] [PATCH V2 04/11] I2C: mxc_i2c: get rid of __REG access

Dear Stefano Babic,

In message 1295513194-16158-5-git-send-email-sbabic@denx.de you wrote:

This driver accesses to processor's register via __REG macros, that are removed (or are planned to be removed) and replaced by C structures. This patches replaces all occurrencies of __REG macros.

Checkpatch says:

total: 0 errors, 2 warnings, 169 lines checked

Please have a look.

...

@@ -204,7 +219,8 @@ int i2c_read(uchar chip, uint addr, int alen, uchar *buf, int len) int i2c_write(uchar chip, uint addr, int alen, uchar *buf, int len) { int timeout = 10000;

• DPRINTF("%s chip: 0x%02x addr: 0x%04x alen: %d len: %d\n",__FUNCTION__, chip, addr, alen, len);

• DPRINTF("%s chip: 0x%02x addr: 0x%04x alen: %d len: %d\n",

• __FUNCTION__, chip, addr, alen, len);
  

While touching this anyway, can we please convert the DPRINTF() into debug() ?

Best regards,

Wolfgang Denk