Hi Albert,
On 29 April 2015 at 01:09, Albert ARIBAUD albert.aribaud@3adev.fr wrote:
Bonjour Simon,
Le Tue, 28 Apr 2015 20:43:47 -0600, Simon Glass sjg@chromium.org a écrit :
Thanks for the various reviews on this series. If there is nothing else, I will pull this in soon.
Seems ok, apart from a few 'implicit declaration' warnings here that do not seem to have been seen by others:
common/cmd_date.c:65:4: attention : implicit declaration of function ‘rtc_set’ [-Wimplicit-function-declaration]
drivers/rtc/ds1374.c: In function ‘rtc_read’: drivers/rtc/ds1374.c:215:2: attention : implicit declaration of function ‘i2c_reg_read’ [-Wimplicit-function-declaration] drivers/rtc/ds1374.c: In function ‘rtc_write’: drivers/rtc/ds1374.c:222:3: attention : implicit declaration of function ‘i2c_reg_write’ [-Wimplicit-function-declaration]
That's because those functions are not defined in he compatibility layer. Presumably the build fails also?
I'll apply what I have (assuming I still don't see any build errors) and send out a patch for this.
Regards, Simon