Hi Martin,
On Mon, Jul 16, 2018 at 5:24 AM, Martin Kaiser lists@kaiser.cx wrote:
diff --git a/arch/arm/include/asm/arch-mx25/imx-regs.h b/arch/arm/include/asm/arch-mx25/imx-regs.h index 1b00ed7..28cebeb 100644 --- a/arch/arm/include/asm/arch-mx25/imx-regs.h +++ b/arch/arm/include/asm/arch-mx25/imx-regs.h @@ -360,7 +360,10 @@ struct cspi_regs { #define IMX_IIM_BASE (0x53FF0000) #define IIM_BASE_ADDR IMX_IIM_BASE #define IMX_USB_BASE (0x53FF4000) -#define IMX_USB_PORT_OFFSET 0x200 +/* This is in contradiction to the imx25 reference manual, which says that
- port 1's registers start at 0x53FF4200. The correct base address for
- port 1 is 0x53FF4400. The kernel uses 0x53FF4400 as well. */
+#define IMX_USB_PORT_OFFSET 0x400
Thanks for adding the comments to the code.
However the correct style for multi-lines comments are like this:
/* * bla bla * bla bla bla */
Thanks