Hi Patrick,
On Wed, 11 Sept 2024 at 00:25, Patrick Rudolph patrick.rudolph@9elements.com wrote:
From: Maximilian Brune maximilian.brune@9elements.com
Write the FADT in common code since it's used on all architectures. Let the cpu code fill out the FADT body by introducing a new weak function acpi_fill_fadt().
Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com Cc: Simon Glass sjg@chromium.org Cc: Bin Meng bmeng.cn@gmail.com
arch/x86/cpu/apollolake/acpi.c | 20 +++------------ arch/x86/cpu/baytrail/acpi.c | 17 +------------ arch/x86/cpu/quark/acpi.c | 19 +------------- arch/x86/cpu/tangier/acpi.c | 25 ++---------------- arch/x86/include/asm/acpi_table.h | 12 --------- arch/x86/lib/acpi_table.c | 23 ----------------- include/acpi/acpi_table.h | 9 +++++++ lib/acpi/acpi_table.c | 42 +++++++++++++++++++++++++++++++ 8 files changed, 59 insertions(+), 108 deletions(-)
This seems the wrong way around to me. We should not need weak functions.
The ACPI_WRITER() should be in each file, then each function should call your common function.
Regards, Simon