Peter,
Also, I'm not seeing anyone defining CONFIG_DDR_ECC_INIT_VIA_DMA for 83xx. I don't see any reason not to use DMA on 83xx.
- k
On Jul 8, 2009, at 4:13 AM, Stefan Roese wrote:
Hi Peter,
this patch breaks some PPC4xx boards. Those enabling CONFIG_DDR_ECC, e.g. canyonlands:
[stefan@stefan-desktop u-boot-ppc4xx (master)]$ ./MAKEALL canyonlands Configuring for canyonlands board... fsl_dma.c:50:2: error: #error "Freescale DMA engine not supported on your processor" make[1]: *** No rule to make target `.depend', needed by `libdma.a'. Stop.
On Wednesday 01 July 2009 00:15:51 Peter Tyser wrote:
<snip>
+++ b/include/asm-ppc/config.h @@ -30,8 +30,9 @@ #endif
#ifndef CONFIG_FSL_DMA -#if defined(CONFIG_DDR_ECC) && ! defined(CONFIG_ECC_INIT_VIA_DDRCONTROLLER) && \ - (defined(CONFIG_MPC85xx) || defined(CONFIG_MPC86xx)) +#if ((!defined CONFIG_MPC83xx && defined(CONFIG_DDR_ECC) && \
- !defined(CONFIG_ECC_INIT_VIA_DDRCONTROLLER)) || \
- (defined(CONFIG_MPC83xx) && defined(CONFIG_DDR_ECC_INIT_VIA_DMA)))
#define CONFIG_FSL_DMA #endif #endif
The #if construct doesn't seem to work for all PPC boards. I have to admit that I don't understand the logic enabling the CONFIG_FSL_DMA define. It would be great if you (or somebody else with the FSL insight) could fix this.
Thanks.
Best regards, Stefan
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de =====================================================================