Re: [U-Boot] [PATCH] treewide: compress lines for immediate return

2016-09-02 23:12 GMT+09:00 Marek Vasut marex@denx.de:

On 09/02/2016 03:09 PM, Masahiro Yamada wrote:

...

2016-09-02 20:58 GMT+09:00 Marek Vasut marex@denx.de:

...

On 09/02/2016 12:36 PM, Masahiro Yamada wrote:

...

-ret = expression; -if (ret)

•    return ret;
  

-return 0; +return expression;

Signed-off-by: Masahiro Yamada yamada.masahiro@socionext.com

The thing I miss in the commit message is -- why is this change beneficial/needed ?

I thought the benefit was apparent.

Wasn't it to you?

Nope, please explain.

This is a cleanup patch; it removes unneeded variable assignments, if conditionals.