Dear Alex Dubov,
In message 3287.56311.qm@web37604.mail.mud.yahoo.com you wrote:
Just a general observation: if you are not sure that tlb/law files can be safely factored out and most of the ddr.c files are actually board specific overrides (common part being less than 10 lines) why had you requested me to create a common board hierarchy for these STX boards in the first place?
I am sure that the tlb/law files can be safely factored out, but that does not mean that you can simply use one of the files and force it upon the othe rboards. The differences between the boards must obviously been taken care of, for example by using preprocessor variables (defined in the board config files) to describe the (tiny) differences between the boards.
I don't understand why you claim the ddr.c files were so different:
-> diff board/stxgp3/ddr.c board/stxssa/ddr.c | wc -l 0
As you can see, there is absolutely no difference between the existing ddr.c files - they are absolutely identical.
For all I can see, they don't have any common, vendor specific hardware.
Yet the code looks very much the same, doesn't it?
I still want my board supported, so I propose you decide how do you want them arranged (vendor/board/ or just board/) and I'll limit my contribution to my board's files exclusively.
After all, I don't work for Silicon Turnkey and it starts taking too much time.
I can understand your position, but I am not going to accept yet another copy of the same files. When the first board gets added, it is often next to impossible to know what is common code and what is board specific. When the second board gets added, it's still difficult to decide if it's just coincidence. But when the third board attempts to add the same stuff again, then the situation is clear. It's unfortunate for you that you are triggering the needed cleanup, but that's how it works. Not only for you, but for all of us.
Best regards,
Wolfgang Denk