Re: [U-Boot] env_mmc: support overriding mmc dev from board code

On Tue, Jan 26, 2016 at 10:52:39AM +0100, Clemens Gruber wrote:

On Tue, Jan 26, 2016 at 10:53:58AM +0800, Peng Fan wrote:

...

Yeah. The patch I wrote include fix write_env, and a function prototype in header file.

If the current patch already applied, I can write a follow up patch.

Thanks, Peng.

Hi Peng,

sorry, I did not know there was already a similar patch.

However, now when looking over your patch, it tries to fix read_env and write_env, which is not necessary, because the device number is stored in struct mmc.

What's missing though is the function prototype in the header.

Tom, should I send a v2 of the patch or a follow-up? Or do you want to fix this up, Peng?

Ah, yes, a prototype would be good, go ahead and do it, thanks!