Re: [PATCH 06/10] arm: stm32mp: improve the error message for smc

On 2/12/20 7:37 PM, Patrick Delaunay wrote:

Add the SMC code and operation for trace on errors.

Signed-off-by: Patrick Delaunay patrick.delaunay@st.com

arch/arm/mach-stm32mp/include/mach/stm32mp1_smc.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-stm32mp/include/mach/stm32mp1_smc.h b/arch/arm/mach-stm32mp/include/mach/stm32mp1_smc.h index 7b9167c356..4ad14f963b 100644 --- a/arch/arm/mach-stm32mp/include/mach/stm32mp1_smc.h +++ b/arch/arm/mach-stm32mp/include/mach/stm32mp1_smc.h @@ -46,8 +46,8 @@ static inline u32 stm32_smc(u32 svc, u8 op, u32 data1, u32 data2, u32 *result) arm_smccc_smc(svc, op, data1, data2, 0, 0, 0, 0, &res);

if (res.a0) {

• pr_err("%s: Failed to exec in secure mode (err = %ld)\n",
  

•        __func__, res.a0);
  

• pr_err("%s: Failed to exec svc=%x op=%x in secure mode (err = %ld)\n",
  

•        __func__, svc, op, res.a0);
  

  return -EINVAL; } if (result)

Acked-by: Patrice Chotard patrice.chotard@st.com

Thanks

Patrice