Hi Rajeshwari,
On Thu, Sep 19, 2013 at 9:42 AM, Rajeshwari Birje < rajeshwari.birje@gmail.com> wrote:
Hi Simon,
Thank you for comments. Will add a check so that it will be executed only for Exynos5420 boards.
Also, I don't think an #ifdef for an SOC is permitted in driver code. Are these registers present in any DWMMC peripheral? I assume that they are a feature of the peripheral and that Samsung has not hacked the peripheral for 5420. If so, then I think it should be a flag passed to add_dwmci() to tell it whether to do this or not.
Regards, Simon
Thanks and Regards, Rajeshwari.
On Thu, Sep 19, 2013 at 11:42 AM, Simon Glass sjg@chromium.org wrote:
Hi Rajeshwari,
On Wed, Sep 11, 2013 at 4:01 AM, Rajeshwari S Shinde < rajeshwari.s@samsung.com> wrote:
SMDK5420 has a new Security Management Unit added for dwmmc driver, hence, configuring the control registers to support booting via eMMC.
Signed-off-by: Alim Akhtar alim.akhtar@samsung.com Signed-off-by: Rajeshwari Shinde rajeshwari.s@samsung.com
Changes in V3: - New patch. drivers/mmc/dw_mmc.c | 7 +++++++ include/dwmmc.h | 12 ++++++++++++ 2 files changed, 19 insertions(+)
diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c index a82ee17..d763949 100644 --- a/drivers/mmc/dw_mmc.c +++ b/drivers/mmc/dw_mmc.c @@ -300,6 +300,13 @@ static int dwmci_init(struct mmc *mmc) struct dwmci_host *host = (struct dwmci_host *)mmc->priv; u32 fifo_size;
dwmci_writel(host, EMMCP_MPSBEGIN0, 0);dwmci_writel(host, EMMCP_SEND0, 0);dwmci_writel(host, EMMCP_CTRL0,MPSCTRL_SECURE_READ_BIT | MPSCTRL_SECURE_WRITE_BIT |MPSCTRL_NON_SECURE_READ_BIT |MPSCTRL_NON_SECURE_WRITE_BIT
|
MPSCTRL_VALID);Is this safe for all users of this file (Exynos5250, etc. ?
Regards, Simon
U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
-- Regards, Rajeshwari Shinde