On 1/2/19 10:00 AM, Lukasz Majewski wrote:
Hi Marek,
On 1/2/19 12:37 AM, Lukasz Majewski wrote:
This patch provides a generic way to setup ENET (ETH) clocks for imx6(q) based boards. Previously this was performed per board in the board_eth_init() function.
Signed-off-by: Lukasz Majewski lukma@denx.de
arch/arm/include/asm/arch-mx6/clock.h | 1 + arch/arm/mach-imx/mx6/clock.c | 17 +++++++++++++++++ 2 files changed, 18 insertions(+)
diff --git a/arch/arm/include/asm/arch-mx6/clock.h b/arch/arm/include/asm/arch-mx6/clock.h index a9481a5fea..9a217349f5 100644 --- a/arch/arm/include/asm/arch-mx6/clock.h +++ b/arch/arm/include/asm/arch-mx6/clock.h @@ -72,6 +72,7 @@ int enable_i2c_clk(unsigned char enable, unsigned i2c_num); int enable_spi_clk(unsigned char enable, unsigned spi_num); void enable_ipu_clock(void); int enable_fec_anatop_clock(int fec_id, enum enet_freq freq); +int set_fec_clock(int fec_id, enum enet_freq freq); void enable_enet_clk(unsigned char enable); int enable_lcdif_clock(u32 base_addr, bool enable); void enable_qspi_clk(int qspi_num); diff --git a/arch/arm/mach-imx/mx6/clock.c b/arch/arm/mach-imx/mx6/clock.c index 366a4e3c6b..8a4fb23090 100644 --- a/arch/arm/mach-imx/mx6/clock.c +++ b/arch/arm/mach-imx/mx6/clock.c @@ -902,6 +902,17 @@ void enable_qspi_clk(int qspi_num) #endif
#ifdef CONFIG_FEC_MXC +static void select_fec_clock_source(int fec_id)
How is the fec_id() used in here ?
I guess that you refer to "int fec_id."
Yes, how is it used ? I guess it is not ... so why is this parameter even here ?
Shouldn't this be part of enable_fec_anatop_clock() ?
The enable_fec_anatop_clock() function is used on several board files
- for example:
http://git.denx.de/?p=u-boot.git;a=blob;f=board/dhelectronics/dh_imx6/dh_imx...
And changing it could break some boards.
The select_fec_clock_source() shall be used to replace several: clrsetbits_le32(&iomuxc_regs->gpr[1], 0x1 << 21, 0x1 << 21);
clauses for imx6 variants.
Moreover, I'd pass 'fec_id' parameter anyway - it may be needed by other imx6 variants.
It can be added when it is needed.