On 10/10/2011 03:38 PM, Wolfgang Denk wrote:
Dear Scott Wood,
In message 4E934EF5.9030302@freescale.com you wrote:
This code is a debug code. As fair as I remember debug print code shall not be break in Linux kernel for easier debugging.
Can you please point me to the respective entry in the CodingStyle file?
Note the last sentence:
...
with a long argument list. However, never break user-visible strings such as printk messages, because that breaks the ability to grep for them.
Well, "user-visible strings" is definitely not the same thing as "debug print code", at least not for me.
They're visible to a user that has #defined DEBUG. They're something one might want to grep on. checkpatch.pl explicitly considers pr_debug/dev_dbg to be part of the set of functions that can go over the limit (it just doesn't know about U-Boot's plain old "debug()"). But whatever...
At some point you might want to consider actually writing down your interpretations of these things into a U-Boot coding style document, so at least we don't have to guess.
-Scott