Re: [PATCH v12 2/8] drivers: clk: add fu740 support

Sorry for replying late. Yes, it's a typo. I'll send a patch to fix that and also fix some function names without 'e' in the same file.

Thanks, - Green

On Wed, Jun 16, 2021 at 3:12 AM Andreas Schwab schwab@linux-m68k.org wrote:

On Mai 27 2021, Green Wan wrote:

...

+/* List of clock controls provided by the PRCI */ +struct __prci_clock __prci_init_clocks_fu740[] = {

• [PRCI_CLK_COREPLL] = {
  

•         .name = "corepll",
  

•         .parent_name = "hfclk",
  

•         .ops = &sifive_fu740_prci_wrpll_clk_ops,
  

•         .pwd = &__prci_corepll_data,
  

• },
  

• [PRCI_CLK_DDRPLL] = {
  

•         .name = "ddrpll",
  

•         .parent_name = "hfclk",
  

•         .ops = &sifive_fu740_prci_wrpll_clk_ops,
  

•         .pwd = &__prci_ddrpll_data,
  

• },
  

• [PRCI_CLK_GEMGXLPLL] = {
  

•         .name = "gemgxlpll",
  

•         .parent_name = "hfclk",
  

•         .ops = &sifive_fu740_prci_wrpll_clk_ops,
  

•         .pwd = &__prci_gemgxlpll_data,
  

• },
  

• [PRCI_CLK_DVFSCOREPLL] = {
  

•         .name = "dvfscorepll",
  

•         .parent_name = "hfclk",
  

•         .ops = &sifive_fu740_prci_wrpll_clk_ops,
  

•         .pwd = &__prci_dvfscorepll_data,
  

• },
  

• [PRCI_CLK_HFPCLKPLL] = {
  

•         .name = "hfpclkpll",
  

•         .parent_name = "hfclk",
  

•         .ops = &sifive_fu740_prci_wrpll_clk_ops,
  

•         .pwd = &__prci_hfpclkpll_data,
  

• },
  

• [PRCI_CLK_CLTXPLL] = {
  

•         .name = "cltxpll",
  

•         .parent_name = "hfclk",
  

•         .ops = &sifive_fu740_prci_wrpll_clk_ops,
  

•         .pwd = &__prci_cltxpll_data,
  

• },
  

• [PRCI_CLK_TLCLK] = {
  

•         .name = "tlclk",
  

•         .parent_name = "corepll",
  

•         .ops = &sifive_fu740_prci_tlclksel_clk_ops,
  

• },
  

• [PRCI_CLK_PCLK] = {
  

•         .name = "pclk",
  

•         .parent_name = "hfpclkpll",
  

•         .ops = &sifive_fu740_prci_hfpclkplldiv_clk_ops,
  

• },
  

• [PRCI_CLK_PCIEAUX] {
  

•         .name = "pciaux",
  

Shouldn't that be called "pcieaux"?

Andreas.

-- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."