On 06/26/2018 03:51 AM, Bin Meng wrote:
Hi Alex,
On Tue, Jun 26, 2018 at 12:47 AM, Alexander Graf agraf@suse.de wrote:
On 06/23/2018 10:37 AM, Bin Meng wrote:
Hi Alex,
On Thu, Jun 21, 2018 at 11:13 PM, Alexander Graf agraf@suse.de wrote:
Varargs differ between sysv and ms abi. On x86_64 we have to follow the ms abi though, so we also need to make sure we use x86_64 varargs helpers.
This patch introduces generic efi vararg helpers that adhere to the respective EFI ABI. That way we can deal with them properly from efi loader code and properly interpret variable arguments.
This fixes the InstallMultipleProtocolInterfaces tests in the efi selftests on x86_64 for me.
Signed-off-by: Alexander Graf agraf@suse.de
Thanks, applied to efi-next
I applied this patch on my x86 tree and tested there, but qemu-x86_64_defconfig still fails when 'bootefi selftest'. Anything I am missing?
Where does it fail? There is basically this pitfall and setjmp/longjmp that can easily go wrong.
It just reboots without printing any error message. You can reproduce this in the latest u-boot/master.
How do you run this? I tried the qemu x86_64 target, but it complains about a missing serial driver. I guess I need to pass some DT in?
Alex
$ qemu-system-x86_64 -nographic -pflash u-boot.rom -m 1G WARNING: Image format was not specified for 'u-boot.rom' and probing guessed raw. Automatically detecting the format is dangerous for raw images, write operations on block 0 will be restricted. Specify the 'raw' format explicitly to remove the restrictions.
U-Boot SPL 2018.07-rc2-00066-gebea1f8367 (Jun 26 2018 - 13:13:34 +0200) CPU: x86_64, vendor AMD, device 663h Trying to boot from SPI Jumping to 64-bit U-Boot: Note many features are missing No serial driver found QEMU: Terminated