Hi,
-----Original Message----- From: Marek Vasut marex@denx.de Sent: Wednesday, September 25, 2024 2:32 AM To: Chee, Tien Fong tien.fong.chee@intel.com; u-boot@lists.denx.de Cc: Simon Goldschmidt simon.k.r.goldschmidt@gmail.com; Meng, Tingting tingting.meng@intel.com; Yuslaimi, Alif Zakuan alif.zakuan.yuslaimi@intel.com; Hea, Kok Kiang kok.kiang.hea@intel.com Subject: Re: [PATCH v1 04/20] arm: socfpga: agilex5: Add low level initialization
On 9/24/24 5:14 AM, Chee, Tien Fong wrote:
Hi,
diff --git a/arch/arm/mach-socfpga/Makefile b/arch/arm/mach-socfpga/Makefile index 67c6a8dfec5..53c91d1d2a5
100644
--- a/arch/arm/mach-socfpga/Makefile +++ b/arch/arm/mach-socfpga/Makefile @@ -58,6 +58,7 @@ endif
ifdef CONFIG_TARGET_SOCFPGA_AGILEX5 obj-y += clock_manager_agilex5.o +obj-y += lowlevel_init_agilex5.o obj-y += mailbox_s10.o obj-y += misc_soc64.o obj-y += mmu-arm64_s10.o
Can this be wired into existing early hook function, like s_init or so ?
I cannot find the caller for s_init, wonder where is the s_init is called?
arch/arm/cpu/armv7/lowlevel_init.S:.pushsection .text.s_init, "ax" arch/arm/cpu/armv7/lowlevel_init.S:WEAK(s_init) arch/arm/cpu/armv7/lowlevel_init.S:ENDPROC(s_init) arch/arm/cpu/armv7/lowlevel_init.S: bl s_init
Maybe such a default lowlevel_init for armv8 could also have an s_init ?
What's concern with lowlevel_init()? It's also wired into existing early hook function which's located inside start.S
I would like to avoid duplicating lowlevel_init functionality as much as possible , common lowlevel_init would be very welcome .
Sure, I can add the s_init to common lowlevel_init and moving the codes to s_init.
Thanks.
Regards, Tien Fong