Re: [U-Boot-Users] [Patch] Disable icache before call the first line of kernel in do_bootelf().

In message 1186558396.17519.11.camel@sevens.analog.com you wrote:

Thank you for your comment. Yes, this may not be necessary for all arch. How about add a hook function for each arch?

Using "weak", right.

I find the icache is also disabled before call a binary in common code do_go(). See following snip. Should these lines be conditional?

Ummm...

int do_go (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[]) { ulong addr, rc; int rcode = 0;

    if (argc < 2) {
            printf ("Usage:\n%s\n", cmdtp->usage);
            return 1;
    }

    addr = simple_strtoul(argv[1], NULL, 16);
    printf ("## Starting application at 0x%08lX ...\n", addr);

    if (icache_status()){
           icache_disable();
    }
    if (dcache_status()) {
           dcache_disable();
    }

This is not in the official tree, and it will not make it there. It will probably not even build for many boards.

Best regards,

Wolfgang Denk