Hi André,
On Sat, 13 Apr 2019 22:40:03 +0100 André Przywara andre.przywara@arm.com wrote: ...
I've dropped all applied patches of this series now, some of them introduced dm video_ansi test error [1]. Please fix. Thanks!
Hmh, good one. Didn't find an easy way to get to the bottom of this within the ut test system, so I copied the ANSI sequences out and replayed them with a custom command, inspecting the (sandbox) screen manually. Is there a canonical way to trace down those issues?
You can build sandbox defconfig an run U-Boot with "--show_lcd" option, then run the "ut dm video_ansi" command to inspect the rendered characters and colors, e.g.:
$ make sandbox_defconfig $ make $ ./u-boot -d arch/sandbox/dts/test.dtb -l
U-Boot 2019.04-00326-g7b64a70a3a (Apr 14 2019 - 14:37:44 +0200)
Model: sandbox DRAM: 128 MiB MMC: mmc2: 2 (SD), mmc1: 1 (SD), mmc0: 0 (SD) In: serial Out: vidconsole Err: vidconsole Model: sandbox SCSI: Net: eth0: eth@10002000, eth5: eth@10003000, eth3: sbe5, eth1: eth@10004000 Hit any key to stop autoboot: 0 => ut dm video_ansi Test: dm_test_video_ansi: video.c Failures: 0
In the "U-Boot" window you will see the output of the video_ansi test.
Without your fix for masking bit 3 in the bg index, the high-intensity background colors will be used, you will see brighter BG colors. The test expects results for standard background colors (indexes 0-7).
Anyway, the fix for patch 2/8 is rather simple (see below), do you want to fix this up in your tree? Or shall I sent a v2?
Thanks! I've merged your fix for patch 2/8, no need to resend. Build- testing now.
-- Anatolij