Re: [U-Boot] [PATCH] The cache flush using coprocessor must be in lib_arm/cache-cp15.c

On 17:51 Thu 28 May , Kim, Heung Jun wrote:

Hi? I'm about to suggest one more thing related to "change cpu.c under cpu/arm_cortexa8 dir to common code.".

asm ("mcr p15, 0, %0, c7, c5, 0": :"r" (0));

It's the common feature all over the arm core, not only arm cortex A8. The common cache function is defined in the lib_arm/cache-cp15.c as you know. So, It's seems the better method that cache_flush() is moved to lib_arm/cache-cp15.c

NACK

to boot linux we are suppose to clean both cache I and DCache

the I/DCache flush is armv and arch dependant (example ARM7TDMI, armv4wt, armv3, armv7, etc...)

so for now please let it in cpu/$(ARCH)/cpu.c

Best Regards, J.