On 11.08.17 18:00, Heinrich Schuchardt wrote:
On 08/11/2017 12:11 PM, Alexander Graf wrote:
On 05.08.17 21:32, Heinrich Schuchardt wrote:
To understand what happens in OpenProtocol it is necessary to know the protocol interface GUID. Let's write a debug message.
Using uuid_guid_get_str would be quite clumsy for this purpose. This would involve evaluating _DEBUG which probably should not be used outside common.h.
Cc: Rob Clark robdclark@gmail.com Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de
I agree with Rob that a printf extension would be the nicest way to go here. We could then just use that instead of the %p in EFI_ENTRY() that we have today.
Alex
Hello Alex,
I am aware of [PATCH 4/5] vsprintf.c: add GUID printing,
I just wonder if you wnat to take this patch series as is and we modify EFI_PRINT_GUID afterwards
or
we I shall remove GUID printing and resend the patch series without it.
I think it's best to keep changes isolated to not stall anyone. Since this is really just a debug enhancement, I think we're best off to drop the GUID printing in this patch set.
Alex