
6 Apr
2007
6 Apr
'07
9:39 p.m.
Dear Niklaus,
in message ev5roc$qoo$1@sea.gmane.org you wrote:
Here my reworked patch. Tried a follow all of your comments.
There are some coding style violations: indentation not by TAB.
Please write comments in English language, thanks.
include/configs/hcu4.h is formatted in a way that makes it mostly unreadable. You may want to clean this up a bit.
You use a private flash driver for something that looks as if it was CFI compatible - why don't you use the CFI driver?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office: Kirchenstr. 5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
"Where shall I begin, please your Majesty?" he asked. "Begin at the
beginning," the King said, gravely, "and go on till you come to the
end: then stop." - Alice's Adventures in Wonderland, Lewis Carroll