[AMD Official Use Only - AMD Internal Distribution Only]
Hi Michal
-----Original Message----- From: Simek, Michal michal.simek@amd.com Sent: Monday, January 20, 2025 1:04 PM To: Erkiaga Elorza, Ibai ibai.erkiaga-elorza@amd.com; u-boot@lists.denx.de Cc: ada@thorsis.com Subject: Re: [U-Boot][PATCH v4 5/5] fpga: add new symbol for fpga_loadb
On 1/20/25 13:43, Ibai Erkiaga wrote:
Adding new symbol for the fpga loadb command which is exclusive to Xilinx. Default value is y for backward compatibility.
Signed-off-by: Ibai Erkiaga ibai.erkiaga-elorza@amd.com
(no changes since v1)
cmd/Kconfig | 7 +++++++ cmd/fpga.c | 8 ++++++-- 2 files changed, 13 insertions(+), 2 deletions(-)
diff --git a/cmd/Kconfig b/cmd/Kconfig index c9600498787..55a8d4189a4 100644 --- a/cmd/Kconfig +++ b/cmd/Kconfig @@ -1186,6 +1186,13 @@ config CMD_FPGA_LOADP Supports loading an FPGA device from a bitstream buffer containing a partial bitstream.
+config CMD_FPGA_LOADB
- bool "fpga loadb - load bitstream"
- default y
- depends on CMD_FPGA && FPGA_XILINX
- help
Supports loading an FPGA device from a bitstream bufferJust trying to wrap my head around how you sorted out these Kconfig entries.
you have in help fpga_commands loadb loadp loadbp
But in Kconfig you have LOADP LOADB LOADBP
Agree, I think the right order should be loadb, loadp, loadbp in a way that first we have the full bitstream programming commands and then the two partial ones.
Also Kconfig description for loadp and loadbp is the same
fpga loadp - load partial bitstream
fpga loadb - load bitstream fpga loadbp - load partial bitstream
That should be also clear. It is loading bitstream in BIT or BIN format.
Agree
Thanks, Michal