Re: [U-Boot] [PATCH v4 6/9] Create a single cmd_call() function to handle command execution

On Saturday 14 January 2012 01:45:54 Simon Glass wrote:

--- a/common/command.c +++ b/common/command.c

+int cmd_call(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) +{

• int result;
• result = (cmdtp->cmd)(cmdtp, flag, argc, argv);
• if (result)

• debug("Command failed, result=%d", result);
  

• return result;

+}

does a static inline in the header produce the same code size or better ?

--- a/include/command.h +++ b/include/command.h

+#ifndef __ASSEMBLY__ +int cmd_call(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]); +#endif /* __ASSEMBLY__ */

move the prototype up to the rest of the !ASSEMBLY code rather than putting it at the end by itself ? -mike