On Sun, 2015-09-13 at 17:42 +0200, Hans de Goede wrote:
index 7c1507b..6aa1bf2 100644 --- a/include/configs/sunxi-common.h +++ b/include/configs/sunxi-common.h @@ -73,6 +73,9 @@ #define CONFIG_SYS_LOAD_ADDR 0x22000000 /* default load address */ #define CONFIG_SYS_TEXT_BASE 0x2a000000 #define CONFIG_PRE_CON_BUF_ADDR 0x2f000000 +/* Note this is primarily set through Kconfig, we redefine it here so that
- we get warnings if the Kconfig value mismatches. */
Mismatches with what? Why can't we just use the Kconfig supplied value throughout?
If there is a piece of code somewhere which cannot use the Kconfig value for some reason and is therefore hardcoded then using BUILD_BUG_ON would be best IMHO. There should also be a comment next to the B_B_ON explaining why that code cannot use the Kconfig value.
+#define CONFIG_SPL_STACK_R_ADDR 0x2fe00000
Ian.