Re: [U-Boot-Users] [PATCH] fix CONFIG_FLASH_CFI_LEGACY compilation

In message 20080112134301.GA6978@discworld.dascon.de you wrote:

On Sat, Jan 12, 2008 at 07:27:49AM +0100, Stefan Roese wrote:

...

No. You CFI/JEDEC rework should be available in the official repository right now. Could be that something slipped though. Best would be if you would provide a patch that adds the missing JEDEC stuff.

Okay - after a closer look, just a small change is required.

Hm... either you got the patch inverse, or something is seriously broken:

case CFI_CMDSET_INTEL_STANDARD: case CFI_CMDSET_INTEL_EXTENDED:

• flash_read_jedec_ids_intel(info);
  

• cmdset_amd_read_jedec_ids(info);
  

  break;

For INTEL flashes use the AMD command set, and ...

case CFI_CMDSET_AMD_STANDARD: case CFI_CMDSET_AMD_EXTENDED:

• flash_read_jedec_ids_amd(info);
  

• cmdset_intel_read_jedec_ids(info);
  

...for AMD flashes use the INTEL command set?

This makes no sense to me.

Best regards,

Wolfgang Denk