Re: [U-Boot] [Patch V3 1/4] [MIPS] Add support for MIPS64 cpus

On Monday 20 August 2012 10:22:23 Zhizhou Zhang wrote:

+void __weak _machine_restart(void) +{ +}

this should be: void __noreturn __weak _machine_restart(void) { while (1); }

there should also be a prototype for this in one of the mips64 headers

+int do_reset(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) +{

• _machine_restart();
• fprintf(stderr, "*** reset failed ***\n");
• return 0;

+}

then this would be: int do_reset(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) { _machine_restart(); } -mike