On Tue, 12 Mar 2024 at 15:30, Peter Robinson pbrobinson@gmail.com wrote:
On Tue, 12 Mar 2024 at 09:55, Sumit Garg sumit.garg@linaro.org wrote:
Hi Peter,
On Tue, 12 Mar 2024 at 15:13, Peter Robinson pbrobinson@gmail.com wrote:
Hi Sumit,
pcie_imx doesn't seem to share any useful code for iMX8MP SoC and it is rather tied to quite old port of pcie_designware driver from Linux which suffices only iMX6 specific needs.
But currently we have the common DWC specific bits which alligns pretty well with DW PCIe controller on iMX8MP SoC. So lets reuse those common bits instead as a new driver for iMX8 SoCs. It should be fairly easy to add support for other iMX8 variants to this driver.
The upstream Linux driver is moving towards a single driver [1] for imx6 -> imx9, would it be possible to add support for all generations to this driver and then remove the old driver?
Sorry but that's not in scope of this patch-set and neither do I possess boards with all the imx* SoC variants.
That would allow this single modern driver and removing the old imx6 specific driver.
Folks interested in this can build up on this patch-set and port other imx* variants and then we could have a single modern driver.
That's fine but I think you should document that this can be future because the case is that these devices are clearly related.
Sure, I suppose it deserves a header comment for the legacy pcie_imx.c driver. If I don't see any other comments for this series then I can make that as a follow-up patch. Otherwise I will fold it into this series.
-Sumit