On Tue, Aug 03, 2021 at 12:12:38PM +0200, Stephan Gerhold wrote:
The logic in msm_generate_mac_addr() was originally taken from the LK bootloader where the serial number is a string and must be parsed first. However, in U-Boot msm_board_serial() returns an u32 and msm_generate_mac_addr() has quite complicated code that will first print it as a hex string and then immediately parse it again.
What this function actually does at the end is to put the serial number encoded as big endian (the order used for the hex string) into the u8 *mac. Use put_unaligned_be32() to do that with bit shifts instead of going through the string format.
This should be slightly more efficient and cleaner but does not result in any functional difference.
Cc: Ramon Fried rfried.dev@gmail.com Signed-off-by: Stephan Gerhold stephan@gerhold.net Reviewed-by: Ramon Fried rfried.dev@gmail.com
Applied to u-boot/next, thanks!