On 10/18/2011 03:05 PM, Jason wrote:
Wolfgang,
On Tue, Oct 18, 2011 at 11:44:37AM +0200, Wolfgang Denk wrote:
Dear Andreas,
In message4E9D4552.5040506@gmail.com you wrote:
I guess it will be doable to have some scripts/prepare-patch which runs a) git format-patch b) checkpatch on the patch c) (configurable subset of) MAKEALL on some clean tree with that patch applied d) append the results to the patch
This tool would implement some kind of CI but utilize the computing power of submitter.
Sounds good. Any takers?
I've been mulling this over, and here's my approach:
1.) modify git to add a hook in format-patch, output is dumped after the '---' and before the diff. We use this the run checkpatch.pl with our config. Our script includes a version tag of checkpatch.pl?
cool!
2.) Add a '--versioning' option to format-patch which will scan the output directory for previous versions of the patch. a.) Use the Message-Id of the first version as an In-Reply-To
- Where do you get the Message-Id from? Isn't the message-id assigned by the mail system? - I would prefer the last version
b.) Migrate patch changelog over from previous version, append '*** ADD CHANGELOG ENTRY HERE ***' c.) enforce [PATCH 1/7 V#] Subject line format.
Don't forget to remove "V#" for the first version.
I think this would be more flexible, and would help many projects, not just u-boot.
Totally agreed!
thx,
Jason.
Regards Simon