On 09/07/19 6:29 PM, Alex Kiernan wrote:
On Tue, Jul 9, 2019 at 6:01 AM Keerthy j-keerthy@ti.com wrote:
Use phys_addr_t for mdio_base address to avoid build warnings on arm64 and dra7. Cast it to uintprt_t before assigning to regs.
Signed-off-by: Grygorii Strashko grygorii.strashko@ti.com Signed-off-by: Keerthy j-keerthy@ti.com Reviewed-by: Tom Rini trini@konsulko.com Acked-by: Joe Hershberger joe.hershberger@ni.com
Changes in v6:
- Added Joe's Ack.
drivers/net/ti/cpsw_mdio.c | 4 ++-- drivers/net/ti/cpsw_mdio.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ti/cpsw_mdio.c b/drivers/net/ti/cpsw_mdio.c index 70f547e6d7..6e8f652011 100644 --- a/drivers/net/ti/cpsw_mdio.c +++ b/drivers/net/ti/cpsw_mdio.c @@ -125,7 +125,7 @@ u32 cpsw_mdio_get_alive(struct mii_dev *bus) return val & GENMASK(15, 0); }
-struct mii_dev *cpsw_mdio_init(const char *name, u32 mdio_base, +struct mii_dev *cpsw_mdio_init(const char *name, phys_addr_t mdio_base, u32 bus_freq, int fck_freq) { struct cpsw_mdio *cpsw_mdio; @@ -144,7 +144,7 @@ struct mii_dev *cpsw_mdio_init(const char *name, u32 mdio_base, return NULL; }
cpsw_mdio->regs = (struct cpsw_mdio_regs *)mdio_base;
cpsw_mdio->regs = (struct cpsw_mdio_regs *)(uintptr_t)mdio_base;I'm missing something... the (uintptr_t) cast - is that a narrowing cast?
Now the cpsw_mdio is used by both 32 bit and 64 bit SoCs. Hence uintptr_t cast helps obscure the type of a pointer.