On Sun, Nov 25, 2012 at 05:02:57PM +0100, Henrik Nordström wrote:
Thanks for your patch reviews. Will fix up your comments and submit a new batch of patches later tonight.
You might want to wait a few days... Somebody else might have comments.
sön 2012-11-25 klockan 16:21 +0100 skrev Luka Perkov:
I think you should add README file in doc directory. It should at least contain information how to add support for new boards and point to the tool used for generating images.
There have long been thougts about moving the SPL DRAM controller parameters to a boot header added by mksunxiboot instead of wiring them into the source.
Which tool for generating images? mksunxiboot? The SPL image is built automatically.
Ah ok, I missed that. So the generated SPL image just needs to be copied on the card ? If yes please put that into README in doc directory.
But yes, a README explaining how to install the SPL would help. We do have a bit of a such README but I see now that it's slightly misplaced as tools/mksunxiboot.README, should move do doc/README.sunxi and expanded a bit.
We should have a short tools/mksunxiboot.README too, so don't delete that one.
Do you have any plans for adding support so the boards can boot from SPI/NAND/NOR, anything else then MMC/SD ?
NAND is coming once we get the NAND controller under reasonable control. It's a little too smart controller to fit nicely in mtd, and not exactly well documented. Plus that many boards are using NAND chips not recognised by u-boot mtd code.
Ok. Booting from NAND is something I would like to have ;)
Support for booting from MMC2 is also coming.
There is no known boards using SPI boot media so this probably will not get added in the near future.
NOR is not supported by the SoC other than in SPI package.
Ok. Thanks for the information.
Luka