On 23.02.21 14:57, Aaron Williams wrote:
I am using the latest pull and it's still crashing.
Now that I have a (free) USB 3 hub I can reproduce this issue. With latest TOT I get this:
=> usb start starting USB... Bus xhci@1680000000000: Register 2000140 NbrPorts 2 Starting the controller USB XHCI 1.00 Bus xhci@1690000000000: Register 2000140 NbrPorts 2 Starting the controller USB XHCI 1.00 scanning bus xhci@1680000000000 for devices... Warning: asix_eth MAC addresses don't match: Address in ROM is 00:0e:c6:b2:7e:cb Address in environment is 02:3f:73:97:d1:00 2 USB Device(s) found scanning bus xhci@1690000000000 for devices... Device not responding to set address.
USB device not accepting new address (error=80000000) WARN halted endpoint, queueing URB anyway. Unexpected XHCI event TRB, skipping... (0eebc260 00000000 13000000 01008401) BUG at drivers/usb/host/xhci-ring.c:503/abort_td()! BUG! resetting ...
As Aaron already mentioned, this only happens when an USB 3 hub is present in the setup. I'll try to dig into this tomorrow but perhaps someone else has some quick ideas?
Thanks, Stefan
-Aaron
On Tuesday, February 23, 2021 2:39:41 AM PST Stefan Roese wrote:
On 23.02.21 11:36, Mark Kettenis wrote:
From: Nicolas Saenz Julienne nsaenzjulienne@suse.de Date: Tue, 23 Feb 2021 10:23:04 +0100
On Tue, 2021-02-23 at 09:15 +0100, Stefan Roese wrote:
Hi Bin, Hi Aaron,
I've added Nicolas to Cc, as he also recently did some work on the physical vs virtual addresses in the xHCI driver.
On 23.02.21 09:07, Bin Meng wrote:
Hi Aaron,
On Tue, Feb 23, 2021 at 3:31 PM Aaron Williams awilliams@marvell.com
wrote:
> I have a follow-up. USB is working on our OcteonTX boards running > 2020.10. It may be something specific to the Octeon port. Note that I > did see a problem where the scratchpad memory is using direct > pointers instead of physical addresses (which will not work on MIPS). > As far as I know, however, the Octeon XHCI controller does not use > the scratchpad memory.
Do you plan to send a patch to convert the scratchpad pointer to physical address?
Nicolas, did your patch also address the scratchpad area (sorry for not looking myself).
Yes, my patch took care of that :).
Ah cool. I missed that patch. Looks like this is exactly what I need to cater for the translation done by the IOMMU on the Apple M1.
Won't be sending that patch then ;)
Nice.
Aaron, it might be that you missed this patch series with your latest mainline xHCI tests a few days ago. Could you please try again with current mainline and report back, if this changes the behavior on Octeon MIPS with USB3 hubs?
Thanks, Stefan
Viele Grüße, Stefan