22 Jul
2022
22 Jul
'22
10:49 a.m.
On 21.07.22 18:11, Oleksandr wrote:
On 19.07.22 17:55, Dmytro Firsov wrote:
Hello Dmytro
First of all, thanks for fixing this issue.
Patch looks good, just a nit below.
Hello Oleksandr,
+ reservation.domid = DOMID_SELF; + reservation.extent_order = 0; + reservation.address_bits = 0;
I think the explicit field's zeroing could be dropped now.
Per my understanding, both of this zeros matters, so I decided to set them explicitly (even with struct zeroing):
- for `extent_order` - zero means "no additional shift for PFN_SHIFT", so we are using 4K pages;
- for `address_bits` - zero means "the user has no addressing restriction".
Best regards,
Dmytro.