On Thursday 16 July 2009 16:46:36 Ron Madrid wrote:
Ron Madrid wrote:
When I submitted patches for my new board SIMPC8313 I recall being told that I had inappropriately initialized some of my environment variables. Most specifically I am interested in having default serverip, ipaddr, and ethaddr environment variables. Is this most appropriately done with a specific #define (such as #define CONFIG_SERVERIP) or within #define CONFIG_EXTRA_ENV_SETTINGS?
You can set CONFIGs for all of these things in your own private build and they'll work, but they're inappropriate for main-line U-boot. I hope the reasoning is obvious.
I'm do not understand why and I see in several include/configs/*.h files that these environment variable are being set as default. I'm guessing that there's something that I'm missing.
the board maintainer decides the default env values, not board users. Ben's comment was probably on the assumption that you are in the latter category. -mike