On Fri, Jul 28, 2017 at 06:48:35AM -0500, Adam Ford wrote:
On Thu, Jul 27, 2017 at 10:50 PM, Lokesh Vutla lokeshvutla@ti.com wrote:
On 7/27/2017 10:33 AM, Adam Ford wrote:
This converts the following to Kconfig: CONFIG_SYS_TEXT_BASE
I left the header file data intact (for now), but I tested this on the omap3_logic_defconfig and am3517_evm_defconfig without any errors. I did this partially because I wanted to retain the message about the value of SYS_TEXT_BASE and how it was decided. The ti_armv7_common.h defined SYS_TEXT_BASE to 0x80800000 when it was not already defined, so that is the number I used for the default.
Signed-off-by: Adam Ford aford173@gmail.com
diff --git a/Kconfig b/Kconfig index bb80ada..11fe2e6 100644 --- a/Kconfig +++ b/Kconfig @@ -325,7 +325,7 @@ config SYS_EXTRA_OPTIONS config SYS_TEXT_BASE depends on ARC || X86 || ARCH_UNIPHIER || ARCH_ZYNQMP || \ (M68K && !TARGET_ASTRO_MCF5373L) || MICROBLAZE || MIPS || \
ARCH_ZYNQ || ARCH_KEYSTONE
ARCH_ZYNQ || ARCH_KEYSTONE || ARCH_OMAP2PLUS depends on !EFI_APP hex "Text Base" helpdefault 0x80800000 if ARCH_OMAP2PLUS ?I was trying to be consistent with other architectures. Nobody else put their defaults here, and if everyone did, it would get cluttered quickly.
Yeah, it will get a little cluttered looking, but no, this is the right way to have default values.