From: Peng Fan peng.fan@nxp.com
Before calling hsearch_r, initialize callback entry to NULL.
Coverity log: " Uninitialized scalar variable (UNINIT) uninit_use_in_call: Using uninitialized value e. Field e.callback is uninitialized when calling hsearch_r. "
Reported-by: Coverity Signed-off-by: Peng Fan peng.fan@nxp.com Cc: Tom Rini trini@konsulko.com Cc: Simon Glass sjg@chromium.org --- common/env_callback.c | 1 + common/env_flags.c | 1 + 2 files changed, 2 insertions(+)
diff --git a/common/env_callback.c b/common/env_callback.c index f4d3dbd..1957cc1 100644 --- a/common/env_callback.c +++ b/common/env_callback.c @@ -97,6 +97,7 @@ static int set_callback(const char *name, const char *value, void *priv)
e.key = name; e.data = NULL; + e.callback = NULL; hsearch_r(e, FIND, &ep, &env_htab, 0);
/* does the env variable actually exist? */ diff --git a/common/env_flags.c b/common/env_flags.c index e682d85..7719355 100644 --- a/common/env_flags.c +++ b/common/env_flags.c @@ -455,6 +455,7 @@ static int set_flags(const char *name, const char *value, void *priv)
e.key = name; e.data = NULL; + e.callback = NULL; hsearch_r(e, FIND, &ep, &env_htab, 0);
/* does the env variable actually exist? */