Re: [EXT] [PATCH v2] ls1028a: use default scan_dev_for_boot

On Fri, Jul 24, 2020 at 02:43:48AM +0000, Andy Tang wrote:

...

-----Original Message----- From: Mian Yousaf Kaukab ykaukab@suse.de Sent: 2020年7月23日 21:41 To: u-boot@lists.denx.de; Andy Tang andy.tang@nxp.com Cc: Priyanka Jain priyanka.jain@nxp.com; Rajesh Bhagat rajesh.bhagat@nxp.com; harninder.rai@nxp.com; sudhanshu.gupta@nxp.com; Poonam Aggrwal poonam.aggrwal@nxp.com; Mian Yousaf Kaukab ykaukab@suse.de Subject: [EXT] [PATCH v2] ls1028a: use default scan_dev_for_boot

Caution: EXT Email

scan_dev_for_efi is supposed to be called from scan_dev_for_boot. However this call is missing for ls1028ardb and ls1028aqds boards. As a result EFI boot doesn’t work. Fix this issue by removing custom definition of scan_dev_for_boot and use the default definition instead.

Signed-off-by: Mian Yousaf Kaukab ykaukab@suse.de

Change-log: v2: -Rename. was: ls1028a: fix EFI boot

https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatch work.ozlabs.org%2Fproject%2Fuboot%2Fpatch%2F20200721143354.14382-1 -ykaukab%40suse.de%2F&data=02%7C01%7Candy.tang%40nxp.com%7 C729286cd9264486fe7e208d82f0e3e21%7C686ea1d3bc2b4c6fa92cd99c5c3 01635%7C0%7C1%7C637311085499253728&sdata=iS6R4NdV3LhAXttKf lgl29Su8TJqfFoBzTCnUl4mAQM%3D&reserved=0 -Remove custom definition of scan_dev_for_boot

include/configs/ls1028aqds.h | 7 ------- include/configs/ls1028ardb.h | 7

2 files changed, 14 deletions(-)

diff --git a/include/configs/ls1028aqds.h b/include/configs/ls1028aqds.h index 7bb740f48e36..8ab943cc640a 100644 --- a/include/configs/ls1028aqds.h +++ b/include/configs/ls1028aqds.h @@ -129,13 +129,6 @@ "run scan_dev_for_boot; " \ "fi; " \ "done\0" \

•   "scan_dev_for_boot=" \
  

•           "echo Scanning ${devtype} " \
  

•                           "${devnum}:${distro_bootpart}...; " \
  

•           "for prefix in ${boot_prefixes}; do " \
  

•                   "run scan_dev_for_scripts; " \
  

•           "done;" \
  

•           "\0" \
    "boot_a_script=" \
            "load ${devtype} ${devnum}:${distro_bootpart} " \
                    "${scriptaddr} ${prefix}${script}; " \ diff --git
  

a/include/configs/ls1028ardb.h b/include/configs/ls1028ardb.h index 07450113269c..3c9358ca4b7a 100644 --- a/include/configs/ls1028ardb.h +++ b/include/configs/ls1028ardb.h @@ -112,13 +112,6 @@ "run scan_dev_for_boot; " \ "fi; " \ "done\0" \

•   "scan_dev_for_boot="                              \
  

•           "echo Scanning ${devtype} "               \
  

•                           "${devnum}:${distro_bootpart}...; "
  

\

•           "for prefix in ${boot_prefixes}; do "     \
  

•                   "run scan_dev_for_scripts; "      \
  

•           "done;"                                   \
  

•           "\0"                                      \
    "boot_a_script="                                  \
            "load ${devtype} ${devnum}:${distro_bootpart} "  \
                    "${scriptaddr} ${prefix}${script}; "    \
  

-- 2.26.2

Reviewed-by: andy.tang@nxp.com

Andy, Are you maintaining nxp tree through which you can queue this patch? Or should I ask Tom to cherry-pick it?

BR, Yousaf