On 1/25/23 19:00, Marek Vasut wrote:
On 1/25/23 18:32, Heinrich Schuchardt wrote:
This configuration setting is only relevant if the board supports USB. It should not be in the main menu but in the USB menu.
Fixes: 5454dea3137d ("usb: hub: allow to increase HUB_DEBOUNCE_TIMEOUT") Signed-off-by: Heinrich Schuchardt heinrich.schuchardt@canonical.com
common/Kconfig | 12 ------------ drivers/usb/Kconfig | 11 +++++++++++ 2 files changed, 11 insertions(+), 12 deletions(-)
diff --git a/common/Kconfig b/common/Kconfig index e3a5e1be1e..0afc01b759 100644 --- a/common/Kconfig +++ b/common/Kconfig @@ -1106,15 +1106,3 @@ config FDT_SIMPLEFB config IO_TRACE bool
-config USB_HUB_DEBOUNCE_TIMEOUT - int "Timeout in milliseconds for USB HUB connection" - depends on USB - default 1000 - help - Value in milliseconds of the USB connection timeout, the max delay to - wait the hub port status to be connected steadily after being powered - off and powered on in the usb hub driver. - This define allows to increase the HUB_DEBOUNCE_TIMEOUT default - value = 1s because some usb device needs around 1.5s to be initialized - and a 2s value should solve detection issue on problematic USB keys. diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig index ebe6bf9498..8b957793ff 100644 --- a/drivers/usb/Kconfig +++ b/drivers/usb/Kconfig @@ -53,6 +53,17 @@ config SPL_DM_USB default n if ARCH_MVEBU default y +config USB_HUB_DEBOUNCE_TIMEOUT + int "Timeout in milliseconds for USB HUB connection" + default 1000 + help + Value in milliseconds of the USB connection timeout, the max delay to + wait the hub port status to be connected steadily after being powered + off and powered on in the usb hub driver. + This define allows to increase the HUB_DEBOUNCE_TIMEOUT default + value = 1s because some usb device needs around 1.5s to be initialized + and a 2s value should solve detection issue on problematic USB keys.
Should this be in 'if USB_HOST' too , i.e. past 'config USB_ONBOARD_HUB'?
With CONFIG_USB_GADGET=y usb_hub.o is built, too. CONFIG_USB_GADGET=y does not imply CONFIG_USB_HOST=y.
This is why I did not create such a dependency.
Best regards
Heinrich