On Thu, 2011-01-13 at 17:02 +1300, Chris Packham wrote:
On Mon, Jan 10, 2011 at 8:02 PM, Heiko Schocher hs@denx.de wrote:
Hello Chris,
Sorry for the late reply, but just looked in patchwork and found that I am responsible for your patch, so ...
Chris Packham wrote:
This adds support for for the PCA9535/PCA9539 family of gpio devices which have 16 output pins.
To let the driver know which devices are 16-pin it is necessary to define CONFIG_SYS_I2C_PCA953X_WIDTH in your board config file. This is used to create an array of {chip, ngpio} tuples that are used to determine the width of a particular chip. For backwards compatibility it is assumed that any chip not defined in CONFIG_SYS_I2C_PCA953X_WIDTH has 8 pins.
Acked-by: Peter Tyser ptyser@xes-inc.com Tested-by: Peter Tyser ptyser@xes-inc.com Signed-off-by: Chris Packham chris.packham@alliedtelesis.co.nz
Changes since v3:
- pca953x_ngpio is now a function in all cases.
- Added Peter's ACK to the commit message.
README | 4 ++ drivers/gpio/pca953x.c | 114 ++++++++++++++++++++++++++++++++++++++---------- 2 files changed, 95 insertions(+), 23 deletions(-)
Compiles with actual u-boot the xpedite* boards, so added to u-boot-i2c.git
Thanks!
bye, Heiko
Thanks I was about to poke the mailing list to find out where things had got to. Did I miss something on http://www.denx.de/wiki/U-Boot/Patches that says look <here> list for a custodian and CC them?
There's a list of custodians at http://www.denx.de/wiki/U-Boot/Custodians , but your GPIO driver doesn't really fall neatly into any one of their areas of responsibility, so it'd be tough to know who to CC. I added a comment to http://www.denx.de/wiki/U-Boot/Patches to mention that appropriate maintainers should be CC-ed, as well as people who might be familiar with the change based on past commits for what its worth.
Best, Peter