Re: [PATCH V3 1/2] fw_env: make flash_io() take buffer as an argument

On Wed, Jan 12, 2022 at 12:47:05PM +0100, Rafał Miłecki wrote:

From: Rafał Miłecki rafal@milecki.pl

It's usually easier to understand code & follow it if all arguments are passed explicitly. Many coding styles also discourage using global variables.

Behaviour of flash_io() was a bit unintuitive as it was writing to a buffer referenced in a global struct. That required developers to remember how it works and sometimes required hacking "environment" global struct variable to read data into a proper buffer.

Signed-off-by: Rafał Miłecki rafal@milecki.pl

Applied to u-boot/master, thanks!