Re: [PATCH v4 01/10] env: nowhere: set default enviroment

On Wed, Jan 22, 2020 at 09:29:56AM +0530, Keerthy wrote:

Set default enviroment so that set_env calls succeed when only ENV_IS_NOWHERE set.

Signed-off-by: Keerthy j-keerthy@ti.com

Changes in v4:

• Reworded commit log

env/nowhere.c | 1 + 1 file changed, 1 insertion(+)

diff --git a/env/nowhere.c b/env/nowhere.c index f5b0a17652..70c3b3e011 100644 --- a/env/nowhere.c +++ b/env/nowhere.c @@ -23,6 +23,7 @@ static int env_nowhere_init(void) { gd->env_addr = (ulong)&default_environment[0]; gd->env_valid = ENV_INVALID;

• env_set_default(NULL, 0);

  return 0;

}

What exactly do you mean by this? Can you give an example or two (code and/or shell) where things didn't work before but do now? And please CC Joe/Wolfgang in the future on env patches, thanks.