Re: [U-Boot] [PATCH] net: See to it that sent data is aligned to the ethernet controllers wishes

On Wed, 19 Aug 2009 15:36:04 +0800 "Liu Dave-R63238" DaveLiu@freescale.com wrote:

...

Currently kirkwood_egiga.c has an 8-byte requirement. This patch is an alternative and replacement for "[PATCH] arm:kirkwood See to it that sent data is 8-byte aligned" sent here

http://lists.denx.de/pipermail/u-boot/2009-August/058829.html

For other devices, I've setup send_alignment to 1.

Basically NACK for it. Why you don't resolve the alignment issue in your driver?

Well, that's what the other patch I sent does (the link above), but there were wishes then to handle this above the driver layer, hence this patch :-)

I'm fine with either way, but if there are other drivers with alignment requirements, I'd prefer this variant.

// Simon