On Tue, Jun 24, 2003 at 10:38:22PM +0200, Wolfgang Denk wrote:
In message 20030624202853.GA15860@zumanetworks.com you wrote:
On Tue, Jun 24, 2003 at 08:24:30PM +0200, Wolfgang Denk wrote:
Me too. What's wrong with the existing code? Where does it cause problems?
in FADS, where ENV_IS_EMBEDDED may or may not be set, depending on how big MONITOR_LENGTH is... (i.e. past FLASH_ENV_BASE or not)
But this is exactly the point of defining MONITOR_LENGTH: _if_ the environment shall be embedded in the U-Boot image (ENV_IS_EMBEDDED will be set), then MONITOR_LENGTH must be big enough to include the environment; and if the environment shall be in a separate flash sector, then MONITOR_LENGTH must be small enough NOT to include the environment.
I don't know who designed it that way (because I don't care about the FADS board), but according to "board/fads/u-boot.lds" the environment on this board is aligned on a 256kB boundary _after_ the U-Boot image. So MONITOR_LENGTH must not include the environment, and ENV_IS_EMBEDDED shall not be set.
In which case NOTHING in environment.c is compiled, and "environment" goes unresolved....
should it JUST be #ifdef CONFIG_ICU862?