Architecture-specific definition files such as
include/asm-ppc/processor.h
should be complete and correct, whether u-boot ,( or whatever app,) uses every single register and value defined in them or not.
Otherwise name the file something else like
"include/asm-ppc/u-boot-centric.h"
That way people will have some inkling that the include file they are reading is not technically complete or accurate.
Regards,
-mike wellington
On 11/7/05, Dan Malek dan@embeddededge.com wrote:
This is why I don't like people just arbitrarily going through the manuals and generating such #defines. If we don't use something, let's not define it. How are you going to test a patch to "fix" this stuff if it isn't used? Just delete it and forget it.
On 11/7/05, Dan Malek dan@embeddededge.com wrote:
On Nov 7, 2005, at 4:00 AM, Stefan Roese wrote:
After a quick look in some other ppc manuals (AMCC and Freescale) this seems to be not only a 440GX problem, but a generic ppc problem. I will prepare a patch for this.
If you just use the proper assembler instructions for the mttb/mftb variants, the assembler will chose the right encoding for the processor model.
I didn't find any code referencing these registers.
This is why I don't like people just arbitrarily going through the manuals and generating such #defines. If we don't use something, let's not define it. How are you going to test a patch to "fix" this stuff if it isn't used? Just delete it and forget it.
Thanks.
-- Dan