Re: [U-Boot-Users] [PATCH 6/6] [new uImage] Move FDT error printing to common fdt_error() routine

Marian Balakowicz wrote:

FDT error handling in PPC do_bootm_linux() shares the same message format. This patch moves error message printing to a helper fdt_error() routine.

Signed-off-by: Marian Balakowicz m8@semihalf.com

lib_ppc/bootm.c | 50 ++++++++++++++++++++++++-------------------------- 1 files changed, 24 insertions(+), 26 deletions(-)

[snip]

@@ -310,8 +306,7 @@ do_bootm_linux(cmd_tbl_t *cmdtp, int flag,

	of_flat_tree = (char *)image_get_load (fdt_hdr);
} else {

• 	puts ("Did not find a flat Flat Device Tree.\n"
  

• 		"Must RESET the board to recover.\n");
  

• 	fdt_error ("Did not find a flat Flat Device Tree");
  

Ouch, I messed that one up pretty badly in the original. Should be "Did not find a Flattened Device Tree" s/flat Flat/Flattened/

[snip]

#endif #ifdef CONFIG_OF_HAS_BD_T if (fdt_bd_t(of_flat_tree) < 0) {

• 	puts ("ERROR: /bd_t node create failed - "
  

• 		"must RESET the board to recover.\n");
  

• 	fdte_error ("/bd_t node create failed");
  

Typo s/fdte_error/fdt_error/

[snip]

FWIIW, with the above changes...

Acked-by: Gerald Van Baren vanbaren@cideas.com

Good improvement, thanks. gvb