On Friday 22 January 2010 13:03:40 Wolfgang Denk wrote:
More tightly integrated non-blocking variants of some CFI flash access functions. Enable with CONFIG_SYS_FLASH_CFI_NONBLOCK These can be useful to erase flash or write complete sectors of flash during a serial data transfer for software updates.
The first version had a strong NACK by Wolfgang Denk because of code duplication. Does this version have a chance for inclusion, or are there other things I have to fix/change to get it to this stage?
The patch is still pretty intrusive - the resulting code is much harder to read, to understand and to debug (in both configurations).
From my point of view the disadvantages compared to the advantages (and the potential number of users of this new feature) don't justify to apply this patch.
Stefan, what do you think?
I have the same feeling. Even though Wolfgang Wegner has put bigger effort into making this less intrusive, it still makes the CFI driver even more complex and less readable.
So I tend to not pull this patch (Sorry Wolfgang).
Cheers, Stefan
-- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office@denx.de