More or less by accident I ran buildman the other day on a box with GCC 6.2.0 cross-compilers. By default it seems that the 6.x series enables more (and new) warnings, so the results were non-clean builds for about two thirds of the armv8 defconfigs. Some of the warnings are cosmectic, but some are genuine bugs (mostly in error handling cases, but still). This is a first bunch of fixes, shamelessly picking the low hanging fruits here. I fixed even the cases where the code itself was correct, to avoid warnings and also not to confuse any readers of the code. Also getting used to ignore warnings leads to eventually missing that one genuine one in the future (been there ...)
In a few cases I made a guess on the fix, please feel free to correct me in the (likely) case I got it wrong.
Applies on top of v2016.11 release.
Cheers, Andre.
P.S. Almost every Freescale board build still complains along the lines of [1]. I spent some time in that file (drivers/ddr/fsl/options.c) and narrowly escaped before I lost the remaining bits of my sanity to the daemons of #ifdef hell. If someone more familiar with that code could take a look and decide whether those definitions either belong into some #ifdef clauses or they should be attributed with __maybe_unused.
[1] http://pastebin.com/TrLSssqU
Andre Przywara (12): ls2080aqds: eth: add missing braces mtd: cfi_flash: fix indentation net: e1000: fix indentation net: ldpaa_eth: add missing braces net: rtl8169: remove unneeded definition marvell: comphy_a3700: fix bitmask usb: eth: r8152_fw: fix indentation davinci: da8xxevm: fix indentation phy: micrel: add missing braces cmd: tpm_test: fix indentation Xilinx ZynqMP: fix minimum SDHCI frequency usb: gadget: remove unused shortname variable
board/davinci/da8xxevm/da850evm.c | 4 ++-- board/freescale/ls2080aqds/eth.c | 3 ++- cmd/tpm_test.c | 4 ++-- drivers/mtd/cfi_flash.c | 4 ++-- drivers/net/e1000.c | 5 ++--- drivers/net/ldpaa_eth/ldpaa_eth.c | 3 ++- drivers/net/phy/micrel.c | 3 ++- drivers/net/rtl8169.c | 3 --- drivers/phy/marvell/comphy_a3700.h | 4 ++-- drivers/usb/eth/r8152_fw.c | 8 ++++---- drivers/usb/gadget/ether.c | 1 - include/configs/xilinx_zynqmp_ep.h | 2 +- 12 files changed, 21 insertions(+), 23 deletions(-)